Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable r.sessionWatcher by default #670

Merged
merged 2 commits into from
Jun 20, 2021

Conversation

renkun-ken
Copy link
Member

What problem did you solve?

Since a file-based session watcher was introduced in #150 one and a half years ago, a lot of features has been implemented around it, and they work well in a wide range of scenarios. This PR changes the status of the session watcher from experimental to normal by enabling r.sessionWatcher by default in the setting as I suggested at #668 (comment).

(If you do not have screenshot) How can I check this pull request?

The setting of r.sessionWatcher is enabled by default.

@ElianHugh
Copy link
Collaborator

ElianHugh commented Jun 14, 2021

Not sure if this fits the scope of the PR, but should we also also pass r.previewDataframe and r.previewEnvironment commands to session watcher by default?

@renkun-ken
Copy link
Member Author

Not sure if this fits the scope of the PR, but should we also also pass r.previewDataframe and r.previewEnvironment commands to session watcher by default?

Yes, I think this PR should address these commands that are introduced before sesssion watcher. It might make sense to check on r.sessionWatcher and if it is enabled, then r.previewDataframe just sends View(X) and r.previewEnvironment sends View(globalenv()) to terminal or otherwise keep the old behavior.

@renkun-ken
Copy link
Member Author

previewEnvironment and previewDataframe are updated so that if session watcher is enabled, then View(globalenv()) and View(symbol) are sent to terminal, respectively; otherwise, fallback to the old behavior.

Copy link
Member

@ManuelHentschel ManuelHentschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@renkun-ken renkun-ken merged commit 9230fb0 into REditorSupport:master Jun 20, 2021
@eitsupi eitsupi mentioned this pull request Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants