-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include test in sdist #2282
Include test in sdist #2282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thanks for the PR, I will make 6.3.1 with this tonight still.
That is, if kroki is going to play along 🤦 |
This is released now. |
Thanks! We'll see if the conda-forge bot picks it up for me, but otherwise
will take a look some time later this weekend.
|
Yep, the bot picked up the release just fine, but needs some help finding the new tests. Of note: |
Yeah, just wanted to report that it's missing. Could you add it too, please? |
I will add examples to sdist, but I will also have a look at how you run the tests and see if we can't maybe run it similarly in our CI pipeline to ensure that it will work correctly for you. |
For the record, I'm from Gentoo and not conda-forge, so it's probably different but our code right now is kinda ugly: https://github.com/gentoo/gentoo/blob/master/dev-python/rdflib/rdflib-6.3.0.ebuild#L42 Long story short:
That said, I haven't had time to recheck much of this, so perhaps there is a better way to solve some of these problems. One thing that would really be helpful is having some marker on tests using Internet, so we could easily deselect them all. |
Thanks a lot! |
Summary of changes
Congratulations on 6.3.0!
A perhaps minor regression from earlier versions is that the
sdist
does not include thetest
folder, which makes it harder for downstreams to use a single source of truth to build and test a reliable package. This restores thetest
folder for sdists.While the tests are of course large, most users' agents (modern
pip
) will prefer fetching the.whl
, so this should create minimal disturbance for most users.Checklist
the same change.
./examples
for new features.CHANGELOG.md
).so maintainers can fix minor issues and keep your PR up to date.