Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[📖] page titles have a non-standard emoji #6372

Closed
wmertens opened this issue May 23, 2024 · 2 comments
Closed

[📖] page titles have a non-standard emoji #6372

wmertens opened this issue May 23, 2024 · 2 comments
Labels
COMP: docs Improvements or additions to documentation STATUS-1: needs triage New issue which needs to be triaged

Comments

@wmertens
Copy link
Member

Suggestion

The emoji between the page title and the tagline is non standard and e.g. Slack renders it as a ? (for example Welcome to Qwik Tutorials ? Qwik Documentation), and my Linux shows the unknown-character glyph on the Chrome tab title.

@wmertens wmertens added COMP: docs Improvements or additions to documentation STATUS-1: needs triage New issue which needs to be triaged labels May 23, 2024
@PatrickJS
Copy link
Member

the problem only happens in production deployment. in preview urls it's fine

@PatrickJS
Copy link
Member

PatrickJS commented May 23, 2024

fixed by #6373

The fix was to revert the polyfill for TextEncoderStream to the original one in the repo. The polyfill I used was code directly from Node.js (needed to fix Bun), but this broke the encoding for Cloudflare build/deploys. I also had tests that the old polyfill failed and the test was testing against the real one.

So, we are deploying the docs in preview and production with different settings, which means different deployment configurations for preview and production. However, we still require the old polyfill to work exactly as it did before which means it's not correct.

I think we need tests to check that we can have emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: docs Improvements or additions to documentation STATUS-1: needs triage New issue which needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants