[🐞] qwikInsights vite plugin does not normalize paths like the qwikVite plugin

[intellix]

Which component is affected?

Qwik Rollup / Vite plugin

Describe the bug

I'm playing with qwikInsights to improve performance of our Qwik app. We're also using qwik-nx to support multiple apps in the same codebase with shared libraries.

I noticed before that the dist directory was hardcoded in the original plugin and did a PR to fix it.

I now have 2 more problems:

• The qwikVite plugin assumes q-insights.json exists within the /dist folder (doesn't take qwikInsights plugin options into account)
• The qwikInsights plugin doesn't normalize paths like the qwikVite plugin does

So this means that if you configure the outDirs in qwikVite, the same value isn't going to work when passing in a value to the qwikInsights plugin:

qwikVite({
  client: {
    outDir: '../../dist/apps/myapp/client',
  },
  ssr: {
    outDir: '../../dist/apps/myapp/server',
  },
  tsconfigFileNames: ['tsconfig.app.json'],
}),
qwikInsights({
  outDir: '../../dist/apps/myapp/client',
  publicApiKey: loadEnv('', '.', '').PUBLIC_QWIK_INSIGHTS_KEY,
}),

In fact, even removing the ../../ from qwikInsights outdir is proving problematic for me as well.

Reproduction

N/A

Steps to reproduce

No response

System Info

N/A

Additional Information

No response

[intellix]

I've looked at the codebase to try and do a PR to fix this myself, but I'm not sure what direction to take it cause it's a little complicated.

• qwikVite.normalizePath depends on options passed into qwikVite({ ... }), and it's not a simple utility function so I'd need to pass in the same options to qwikInsights and create a plugin instance there to use the same normalization
• qwikVite.loadQwikInsights assumes q-insights.json exists within dist, so the options passed into qwikInsights have no effect on where that's going to get loaded into.

I think it would be much easier for me to just move the functionality of the qwikInsights plugin into the qwikVite plugin as it's fairly simple anyway. We could pass a configuration for qwikInsights specifically and if the API_KEY exists, then it could download the bundle for consumption later:

qwikVite({
  client: {
    outDir: '../../dist/apps/myapp/client',
  },
  ssr: {
    outDir: '../../dist/apps/myapp/server',
  },
  insights: {
    outDir: '../../dist/apps/myapp/client',
    publicApiKey: loadEnv('', '.', '').PUBLIC_QWIK_INSIGHTS_KEY,
  },
  tsconfigFileNames: ['tsconfig.app.json'],
}),

Let me know if this is the direction we wanna take and if not, it would be great if someone could point me to an idea of how I can achieve it otherwise.

[mhevery]

@gioboa perhaps you could offer your expertise here.

[gioboa]

Yep. @intellix let's do pair programming