From 06cafc69be50f28e08d6fdeee843fdb9e4ca3f81 Mon Sep 17 00:00:00 2001 From: James Onnen Date: Fri, 30 Jun 2023 18:14:29 -0700 Subject: [PATCH] fix: Suppress binder warning for rogue properties --- .../Shared/Modifiers/Additive/RogueAdditiveProvider.lua | 8 +++++++- .../Modifiers/Multiplier/RogueMultiplierProvider.lua | 8 +++++++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/rogue-properties/src/Shared/Modifiers/Additive/RogueAdditiveProvider.lua b/src/rogue-properties/src/Shared/Modifiers/Additive/RogueAdditiveProvider.lua index eaaada0631..c06a532a37 100644 --- a/src/rogue-properties/src/Shared/Modifiers/Additive/RogueAdditiveProvider.lua +++ b/src/rogue-properties/src/Shared/Modifiers/Additive/RogueAdditiveProvider.lua @@ -4,6 +4,8 @@ local require = require(script.Parent.loader).load(script) +local RunService = game:GetService("RunService") + local Rx = require("Rx") local RxBinderUtils = require("RxBinderUtils") local RxBrioUtils = require("RxBrioUtils") @@ -42,7 +44,11 @@ function RogueAdditiveProvider:Create(additive, source) RoguePropertyModifierUtils.createSourceLink(obj, source) end - self._rogueBinders.RogueAdditive:Bind(obj) + if RunService:IsClient() then + self._rogueBinders.RogueAdditive:BindClient(obj) + else + self._rogueBinders.RogueAdditive:Bind(obj) + end return obj end diff --git a/src/rogue-properties/src/Shared/Modifiers/Multiplier/RogueMultiplierProvider.lua b/src/rogue-properties/src/Shared/Modifiers/Multiplier/RogueMultiplierProvider.lua index 6f1c521838..b8b3fda62b 100644 --- a/src/rogue-properties/src/Shared/Modifiers/Multiplier/RogueMultiplierProvider.lua +++ b/src/rogue-properties/src/Shared/Modifiers/Multiplier/RogueMultiplierProvider.lua @@ -4,6 +4,8 @@ local require = require(script.Parent.loader).load(script) +local RunService = game:GetService("RunService") + local Rx = require("Rx") local RxBinderUtils = require("RxBinderUtils") local RxBrioUtils = require("RxBrioUtils") @@ -42,7 +44,11 @@ function RogueMultiplierProvider:Create(multiplier, source) RoguePropertyModifierUtils.createSourceLink(obj, source) end - self._rogueBinders.RogueMultiplier:Bind(obj) + if RunService:IsClient() then + self._rogueBinders.RogueMultiplier:BindClient(obj) + else + self._rogueBinders.RogueMultiplier:Bind(obj) + end return obj end