Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Shutdown Timeout as Configurable Parameter #134

Open
theonewolf opened this issue Aug 6, 2016 · 2 comments
Open

Expose Shutdown Timeout as Configurable Parameter #134

theonewolf opened this issue Aug 6, 2016 · 2 comments

Comments

@theonewolf
Copy link

Currently, when waitress receives a SIGINT or traps a SystemExit exception, it tries to shutdown the running task dispatcher.

The shutdown method embeds inside its function signature a hardcoded timeout value of 5 seconds.

This should not be hidden nor hardcoded. It should be exposed as a parameter to the operator.

The line of source code I'm talking about is here:

def shutdown(self, cancel_pending=True, timeout=5):

and the only place it's called (I believe, outside of tests):

self.task_dispatcher.shutdown()

@digitalresistor
Copy link
Member

Related:

#48
#56

@digitalresistor
Copy link
Member

See issue comment here: #269 (comment)

The code referenced above wouldn't help solve for shutdown being configurable in terms of the timeout, in fact, because we never call into asyncore.loop we are no longer sending data to the network. This needs much bigger fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants