-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 517 breaks relative dependency in rustapi_module #362
Comments
I'm fine with just removing |
@konstin It may be that Playing around with setting the |
I fully agreed that we should solve the part that affects this repository in this repository. I just wanted to say that depending on pip we might need to split this into two issues where one lives in the setuptools-rust repo. |
Since the very recently released |
This may need to be revisited at some point. Seems like |
So this is a bit of a problem. With
pip >= 19.0
you are automatically opted-in to using PEP 517 if you have apyproject.toml
, and there's no way to get the old behavior of "just install the build dependencies but don't use PEP 517 for the build".This is a bit of a problem because
rustapi_module
has an out-of-source dependency on thepyo3
source root, for obvious reasons, but with PEP 517 the build occurs in a temporary build directory.I don't know enough about how dependencies are specified in Rust to know the right solution here. For now we can disable PEP 517 by removing
pyproject.toml
.Reported upstream at pypa/pip#6276 for tracking purposes, though I think we'll probably have to find our own workarounds.
The text was updated successfully, but these errors were encountered: