Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-toolchain.toml is no longer recognized #215

Closed
stinodego opened this issue Oct 2, 2023 · 3 comments · Fixed by #217
Closed

rust-toolchain.toml is no longer recognized #215

stinodego opened this issue Oct 2, 2023 · 3 comments · Fixed by #217
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@stinodego
Copy link

stinodego commented Oct 2, 2023

A recent update seems to have broken this functionality.

This is a recent run (installs stable, ignoring rust-toolchain.toml):
https://github.com/stinodego/polars/actions/runs/6384664783/job/17327784276

This is a slightly older run of ~6 hours ago (installs nightly as specified in rust-toolchain.toml):
https://github.com/stinodego/polars/actions/runs/6380623219/job/17315365326

Maybe it's because of the working-directory specification? Same issue when not using working-directory.

@messense
Copy link
Member

messense commented Oct 3, 2023

So #213 could have break this.

maturin-action/src/index.ts

Lines 203 to 204 in 3392822

const manifestDir = getManifestDir(args)
const rustToolchainToml = path.join(manifestDir, 'rust-toolchain.toml')

We should walk the directories up to $GITHUB_WORKSPACE to find a rust-toolchain.toml instead of just check it once. I don't have time to fix it today, so pull requests are welcome.

@messense messense added bug Something isn't working good first issue Good for newcomers labels Oct 3, 2023
@messense
Copy link
Member

messense commented Oct 6, 2023

Fixed in #217 and published in v1.

@stinodego
Copy link
Author

Can confirm that this was fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants