Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do API key check on page navigation #163

Closed
hadiahmed098 opened this issue Jun 8, 2022 · 1 comment
Closed

Do API key check on page navigation #163

hadiahmed098 opened this issue Jun 8, 2022 · 1 comment
Labels
code enhancement Improvements to the code without noticeably changing user experience feature enhancement New features and functionality

Comments

@hadiahmed098
Copy link
Member

In the unlikely event that the API key expires on the API side before the UI side, the user can perform several actions and lose plenty of work when an api call fails.

Perform an API key validation check (on a literally dummy endpoint) on page load or route navigation.

Pros: limits a very rare and extremely unlikely edge case.
Cons: generates a lot of extra traffic, can play not nicely with the other mounted api calls.
@hadiahmed098 hadiahmed098 added feature enhancement New features and functionality code enhancement Improvements to the code without noticeably changing user experience labels Jun 8, 2022
@hadiahmed098 hadiahmed098 mentioned this issue Jun 8, 2022
Open
@hadiahmed098
Copy link
Member Author

With #164, this feature would actually be useful as the UI key has no expiry now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code enhancement Improvements to the code without noticeably changing user experience feature enhancement New features and functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hadiahmed098