Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why don't we have repo-signing? #206

Open
Jaykul opened this issue Nov 29, 2021 · 2 comments
Open

Why don't we have repo-signing? #206

Jaykul opened this issue Nov 29, 2021 · 2 comments

Comments

@Jaykul
Copy link

Jaykul commented Nov 29, 2021

It seems that while nuget has added various ways of validating content, PowerShell is stuck with just code and cab signing mechanisms that rely on authors -- and very, very few authors are signing.

Specifically, Nuget hashes and provides hash files, and does repo-signing (and counter-signs pre-signed packages).

https://github.com/NuGet/Home/wiki/Nupkg-Metadata-File
https://devblogs.microsoft.com/nuget/introducing-repository-signatures/

Microsoft, of course, is also providing spdx files in their modules, in addition to code-signing, etc.

https://devblogs.microsoft.com/engineering-at-microsoft/generating-software-bills-of-materials-sboms-with-spdx-at-microsoft/

@dbaileyut
Copy link

Agreed.

For example, see: AccessControlDSC

It purports to be from Microsoft, but as far as I can tell, it's hosted in a personal repo. I can see contributions from folks with Microsoft in their GitHub profiles. I've reviewed the code and it looks good... So, it looks legit but how am I supposed to know if this is actually a Microsoft module? Should I be reporting it for saying it's from Microsoft? Should I contact the owners? - what if they are malicious and lie to me?

@alerickson
Copy link
Member

alerickson commented Oct 24, 2022

@dbaileyut we're currently running scripts to validate newly published modules to check if they're spoofing or typo squatting. This a short term solution as we work on more thorough ways to validate packages. In the long term, we'd like to work on implementing security feature akin to what @Jaykul has mentioned. Please feel free to add any suggestions here.

Edit:
@dbaileyut I just looked and validated that AccessControlDSC is actually a Microsoft module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants