Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(home): adjust padding between sections for iPad layout #699

Merged
merged 2 commits into from
May 3, 2023
Merged

fix(home): adjust padding between sections for iPad layout #699

merged 2 commits into from
May 3, 2023

Conversation

cyndichin
Copy link
Contributor

@cyndichin cyndichin commented May 3, 2023 •
edited
Loading

Summary

Adjust padding between sections in Home tab for iPad layout

References

IN-1386

Implementation Details

  • Update padding to be consistent with the spacing between recent saves and editor's pick

Test Steps

Run app and verify there is no longer inconsistent space between section

PR Checklist:

  • N / A Added Unit / UI tests
  • Self Review (review, clean up, documentation, run tests)
  • Basic Self QA

Screenshots

@pocket-ci
Copy link
Contributor

pocket-ci commented May 3, 2023 •
edited
Loading

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 76.59%
📖 Checking XCode Environment Variables
📖 Edited 1 files
📖 Created 0 files

PocketKit: Coverage: 76.83

File Coverage
HomeCollectionViewSectionProvider.swift 71.13% ✅

Generated by 🚫 Danger Swift against 1cb71c5

@cyndichin cyndichin force-pushed the fix/IN-1386_inconsistent-spacing-between-sections branch from 692e7ea to 1cb71c5 Compare May 3, 2023 19:24
@cyndichin cyndichin marked this pull request as ready for review May 3, 2023 20:09
@cyndichin cyndichin requested a review from a team as a code owner May 3, 2023 20:09
@cyndichin cyndichin requested review from dskuza and nzeltzer and removed request for a team May 3, 2023 20:09
@cyndichin cyndichin enabled auto-merge (rebase) May 3, 2023 20:15
@cyndichin cyndichin merged commit a5490d1 into develop May 3, 2023
@cyndichin cyndichin deleted the fix/IN-1386_inconsistent-spacing-between-sections branch May 3, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassrock bassrock bassrock approved these changes

@dskuza dskuza Awaiting requested review from dskuza dskuza was automatically assigned from Pocket/ios

@nzeltzer nzeltzer Awaiting requested review from nzeltzer nzeltzer was automatically assigned from Pocket/ios

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyndichin @pocket-ci @bassrock