fix(swipe): do not call completion handler on list cell swipe actions #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves an issue where there would be a glitchy animation where the cell would be resetting its swipe state, while also getting deleted due to an archive / move to saves
dskuza
requested review from
nzeltzer and
timc-mozilla
and removed request for
a team
bassrock
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves an issue where there would be a glitchy animation where the cell would be resetting its swipe state, while also getting deleted due to an archive / move to saves
Implementation Details
See added code comment.
Test Steps
Swipe and tap "Archive" from an item in Saves; there should be a single animation of the cell getting deleted
Long-swipe to "Archive" from an item in Saves; there should be a single animation of the cell getting deleted
Swipe and tap "Move to Saves" from an item in Archive; there should be a single animation of the cell getting deleted
Long-swipe to "Move to Saves" from an item in Archive; there should be a single animation of the cell getting deleted
PR Checklist: