Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coredata): make Item optional on SavedItem #690

Merged
merged 3 commits into from
May 2, 2023

Conversation

cyndichin
Copy link
Contributor

Summary

Set Item back to non-optional on SavedItem since there are scenarios such as extension and offline where we can't create an Item (which is server backed)

References

See convo here:
https://pocket.slack.com/archives/C01UH57EJKD/p1683046168112139?thread_ts=1683042594.907889&cid=C01UH57EJKD

Implementation Details

  • Make Item optional on SavedItem
  • Fix build errors for compiling project and running tests

Test Steps

  1. Save an article to Pocket via Share Extension on airplane mode
  2. Navigate to Saves List
  3. Validate that no crash occurs

PR Checklist:

  • N / A Added Unit / UI tests
  • Self Review (review, clean up, documentation, run tests)
  • Basic Self QA

Screenshots

@pocket-ci
Copy link
Contributor

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 76.57%
📖 Checking XCode Environment Variables
📖 Edited 16 files
📖 Created 0 files

PocketKit: Coverage: 76.76

File Coverage
SavedItem+ItemsListItem.swift 78.43%
SavedItem+Listen.swift 0.0% ⚠️
SavedItemsListViewModel.swift 83.59%
Item+Extensions.swift 88.24%
ListenViewModel.swift 0.0% ⚠️
HomeViewModel.swift 78.14%
SavedItemViewModel.swift 86.21%

Sync: Coverage: 84.51

File Coverage
PocketSource.swift 84.9%
SavedItem+CoreDataProperties.swift 100.0%
CoreDataSpotlightDelegate.swift 93.1%

Generated by 🚫 Danger Swift against e7e73a0

@cyndichin cyndichin marked this pull request as ready for review May 2, 2023 17:35
@cyndichin cyndichin requested a review from a team as a code owner May 2, 2023 17:35
@cyndichin cyndichin requested review from nzeltzer and timc-mozilla and removed request for a team May 2, 2023 17:35
@cyndichin cyndichin enabled auto-merge (rebase) May 2, 2023 17:39
@cyndichin cyndichin merged commit 3120789 into develop May 2, 2023
@cyndichin cyndichin deleted the fix/make-item-optional branch May 2, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants