fix(coredata): make Item optional on SavedItem #690
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Set Item back to non-optional on SavedItem since there are scenarios such as extension and offline where we can't create an Item (which is server backed)
References
See convo here:
https://pocket.slack.com/archives/C01UH57EJKD/p1683046168112139?thread_ts=1683042594.907889&cid=C01UH57EJKD
Implementation Details
Item
optional onSavedItem
Test Steps
PR Checklist:
Screenshots