feat(analytics): add tag name(s) as tag event value #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dskuza
requested review from
cyndichin and
timc-mozilla
and removed request for
a team
timc-mozilla
approved these changes
Apr 26, 2023
Analytics: Coverage: 29.76
PocketKit: Coverage: 20.15
SaveToPocketKit: Coverage: 29.16
SharedPocketKit: Coverage: 51.65
Generated by 🚫 Danger Swift against 5f09963 |
Gio2018
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Looks good to me @dskuza ! side note: it's be nice if we could see those values represented in the console somehow, but I feel this is a broader scope than just tag-related engagement events, so it does not concern this particular PR.
cyndichin
approved these changes
Apr 26, 2023
| static func remoteInputTag(itemUrl: URL) -> Event { | ||
| /// - Parameters: | ||
| /// - tag: The tag that was removed from the list of input tags. | ||
| /// /// - itemUrl: The url of the item to which a tag was removed. |
There was a problem hiding this comment.
nit: extra /// also in Tags.swift
dskuza
force-pushed
the
tag-analytics-adding-value
branch
from
5f09963
to
12fb233
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds tag name(s) as tag event values to tag events sent from both the app and the Save extension.
References
IN-1355
Implementation Details
A
tag(Name)parameter was added to the appropriate static functions to add avalueto theEngagementevent. The correct functions were then updated to supply the correct name(s), either by utilizing a string in a calling function, or aTagTypeas appropriate.Test Steps
valuefield.PR Checklist: