fix(listen): adding in baseline listen analytics #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassrock
requested review from
cyndichin and
CMasterson
and removed request for
a team
bassrock
commented
Apr 14, 2023
| } | ||
|
|
||
| func listenDidDismissPlayer(_ player: PKTListenAudibleQueuePresentationContext) { | ||
| } | ||
|
|
||
| func listenDidDismiss() { | ||
| tracker.track(event: Events.Listen.Closed()) |
There was a problem hiding this comment.
You'll need to ask @nzeltzer why there are 2 call backs :)
Analytics: Coverage: 71.68
PocketKit: Coverage: 78.08
Generated by 🚫 Danger Swift against 9bdbd50 |
cyndichin
approved these changes
Apr 17, 2023
|
@cyndichin yes once we get accesibility identifiers added to listen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds in callbacks to listen, for listen analytics
Implementation Details
PR Checklist:
Screenshots