fix(tests): battle hardened tests against multiple device sizes #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassrock
requested review from
nzeltzer and
Gio2018
and removed request for
a team
bassrock
commented
Apr 10, 2023
| @@ -21,7 +21,8 @@ class TagsFilterViewModel: ObservableObject { | |||
| } | |||
|
|
|||
| func getAllTags() -> [TagType] { | |||
| arrangeTags(with: fetchedTags?.compactMap({ $0.name }) ?? []) | |||
| // Finding unique elements using set | |||
| arrangeTags(with: Array(Set(fetchedTags?.compactMap({ $0.name }) ?? []))) | |||
There was a problem hiding this comment.
I had to do this, because at times the FilterTagsView would contain duplicate tags. Should be fixed in #568
bassrock
commented
Apr 10, 2023
| allTags.append(contentsOf: fetchedTags) | ||
| } | ||
| return allTags.compactMap { TagType.tag($0) } | ||
| return tags.sorted().compactMap { TagType.tag($0) } |
There was a problem hiding this comment.
removing recent tags instead for #568
bassrock
commented
Apr 10, 2023
| @@ -212,8 +212,8 @@ workflows: | |||
| ## It uses the values in MICRO_IGLU_REGISTRY_URL and MICRO_IGLU_API_KEY | |||
| echo "Run snowplow" | |||
| brew install wget openjdk | |||
| wget https://github.com/snowplow-incubator/snowplow-micro/releases/download/micro-1.5.0/snowplow-micro-1.5.0.jar | |||
| java -jar snowplow-micro-1.5.0.jar & | |||
| wget https://github.com/snowplow-incubator/snowplow-micro/releases/download/micro-1.6.0/snowplow-micro-1.6.0.jar | |||
PocketKit: Coverage: 79.75
Sync: Coverage: 88.23
Generated by 🚫 Danger Swift against be61cce |
timc-mozilla
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@timc-mozilla discovered that our test was not battle hardended against small device sizes. This makes use of a scrollTo function to ensure that we scroll to a specific element instead of unless scrolling or assuming something is on screen.
This will also fixes flakyness I discovered around tags where tags were always appearing in a different order. This should be fully fixed in #568 and any work here is a stop gap for tests and sanity.
Implementation Details
There are a few helper libraries we could import that would help with our tests, but I chose to use a very basic scrollTo function instead since the one I found had not been updated in a while.
Test Steps
PR Checklist:
Screenshots