chore(tests): ensuring graphql responses don't change after launch #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassrock
force-pushed
the
graphql-test-mutation
branch
from
60594ca
to
ba25d83
Compare
Analytics: Coverage: 85.42
Sync: Coverage: 88.28
Generated by 🚫 Danger Swift against cc2c82d |
bassrock
changed the title
bassrock
requested review from
CMasterson and
Gio2018
and removed request for
a team
cyndichin
approved these changes
Apr 7, 2023
| let addTagEvent = await snowplowMicro.getFirstEvent(with: "global-nav.addTags.addTag") | ||
| addTagEvent!.getUIContext()!.assertHas(type: "button") | ||
| addTagEvent!.getContentContext()!.assertHas(url: "http://localhost:8080/hello") | ||
| let events = await [snowplowMicro.getFirstEvent(with: "global-nav.addTags.removeInputTag"), snowplowMicro.getFirstEvent(with: "global-nav.addTags.addTag")] |
Gio2018
approved these changes
Apr 7, 2023
Comment on lines
+86
to
+88
| space.backgroundContext.performAndWait { | ||
| persistentTask.currentCursor = pageInfo.endCursor | ||
| } |
There was a problem hiding this comment.
As discussed thanks for catching it!
| } | ||
| app.launch() | ||
| app.tabBar.savesButton.wait().tap() |
There was a problem hiding this comment.
would we ever need to also wait for tabBar (or any other ancestor in any other test) existence?
There was a problem hiding this comment.
I think waiting for the savesButton inherently waits for the tab bar but in my experience here... adding more waits does not hurt anything at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Gain confidence in our test suite by shoring up it's reliability. There will be followup PRs to try and do this work iteratively.
See Implementation Details for more info.
References
Implementation Details
Test Steps
PR Checklist:
Screenshots