Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: run swiftlint as strict #560

Merged
merged 1 commit into from
Apr 4, 2023
Merged

build: run swiftlint as strict #560

merged 1 commit into from
Apr 4, 2023

Conversation

dskuza
Copy link
Contributor

@dskuza dskuza commented Apr 4, 2023

Summary

Runs swiftlint under strict mode to treat warnings as errors.

Implementation Details

  • Update build phase to add --strict to the swiftlint call

PR Checklist:

  • Added Unit / UI tests
  • Self Review (review, clean up, documentation, run tests)
  • Basic Self QA

@dskuza dskuza requested a review from a team as a code owner April 4, 2023 19:16
@dskuza dskuza requested review from nzeltzer and CMasterson and removed request for a team April 4, 2023 19:16
@pocket-ci
Copy link
Contributor

Messages
📖 No SwiftLint violations! 🎉
📖 Edited 1 files
📖 Created 0 files

Generated by 🚫 Danger Swift against 3b387e3

@dskuza dskuza merged commit 4a43e17 into develop Apr 4, 2023
@dskuza dskuza deleted the swiftlint-as-errors branch April 4, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassrock bassrock bassrock approved these changes

@Gio2018 Gio2018 Gio2018 approved these changes

@nzeltzer nzeltzer Awaiting requested review from nzeltzer nzeltzer was automatically assigned from Pocket/ios

@CMasterson CMasterson Awaiting requested review from CMasterson CMasterson was automatically assigned from Pocket/ios

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dskuza @pocket-ci @bassrock @Gio2018