fix(receipts): ensuring there is a receipt #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassrock
requested review from
dskuza and
CMasterson
and removed request for
a team
Gio2018
reviewed
Mar 29, 2023
| @@ -27,6 +27,9 @@ class AppStoreReceiptService: NSObject, ReceiptService { | |||
| } | |||
|
|
|||
| func send(_ product: Product?) async throws { | |||
| // First make sure a receipt even exists before we try and get one. | |||
| _ = try getReceipt() | |||
There was a problem hiding this comment.
wondering if, instead of calling getReceipt() twice, we can just handle the whole thing inside getReceipt() where we already check the existence on disk?
There was a problem hiding this comment.
@Gio2018 up to you. really this method is designed for that throws method in getReceipt
Gio2018
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On iOS simulators when you are logged out of Apple, a system prompt will show if you request a receipt. Instead we should see if a recept exists first
PR Checklist:
Screenshots