Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storekit1): add storekit 1 methods #531

Merged
merged 3 commits into from
Mar 29, 2023
Merged

fix(storekit1): add storekit 1 methods #531

merged 3 commits into from
Mar 29, 2023

Conversation

bassrock
Copy link
Member

@bassrock bassrock commented Mar 29, 2023

Summary

Pocket's backend only knows about StoreKit 1 for the time being. It seems the receipt that gets saved in the receipt URL area is a storeKit 2 receipt and is not compatible with our backend.

So we need to explcitly create a StoreKit 1 receipt request and send that to our backend.

Implementation Details

  • Checked continuations are so cool.

Test Steps

  • Test out purchasing and it should succeed.

PR Checklist:

  • Added Unit / UI tests
  • Self Review (review, clean up, documentation, run tests)
  • Basic Self QA

Screenshots

@bassrock bassrock marked this pull request as ready for review March 29, 2023 15:57
@bassrock bassrock requested a review from a team as a code owner March 29, 2023 15:57
@bassrock bassrock requested review from cyndichin and Gio2018 and removed request for a team March 29, 2023 15:57
Copy link
Contributor

@cyndichin cyndichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good in terms of adding the storeKit 1 method, curious to understand the context of why we are adding them. Do we have to handle cases where receipts were created with StoreKit 1?

@bassrock
Copy link
Member Author

@cyndichin Our server only understands sStoreKit 1, so im explicitly loading a store kit 1 receipt. I dont think StoreKit 2 is working as expected.

@bassrock bassrock merged commit c88054d into develop Mar 29, 2023
@bassrock bassrock deleted the storekit1 branch March 29, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants