Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(imageCache): fixing image cache encoding #516

Merged
merged 3 commits into from
Mar 27, 2023
Merged

fix(imageCache): fixing image cache encoding #516

merged 3 commits into from
Mar 27, 2023

Conversation

bassrock
Copy link
Member

@bassrock bassrock commented Mar 27, 2023

Summary

When using the Pocket Image cache urls need to be URL encoded. Before we were letting URLComponents just do its own thing, which only partially encoded the underlying image url.

We needed to explicitly encode the image url so that the ImageCache service can decode it to the right location.

References

Implementation Details

Encoded the image URL explicit following some legacy code in legacy pocket. Will link upon request in slack (to not post the old repo here)

Test Steps

  • Use Proxyman to watch the image cache and see the requested URLs are all urlencoded as the last part of the path for the Image request

PR Checklist:

  • Added Unit / UI tests
  • Self Review (review, clean up, documentation, run tests)
  • Basic Self QA

Screenshots

@bassrock bassrock marked this pull request as ready for review March 27, 2023 14:32
@bassrock bassrock requested a review from a team as a code owner March 27, 2023 14:32
@bassrock bassrock merged commit f896ecf into develop Mar 27, 2023
@bassrock bassrock deleted the images branch March 27, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants