Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(load): removing extra saves & archive call #494

Merged
merged 2 commits into from
Mar 15, 2023
Merged

fix(load): removing extra saves & archive call #494

merged 2 commits into from
Mar 15, 2023

Conversation

bassrock
Copy link
Member

@bassrock bassrock commented Mar 15, 2023 •
edited
Loading

Summary

I noticed that archive & saves was fetching twice on app launch.

Test Steps

  • Watch the logs on app launch and ensure that FetchSaves and FetchArchive is only requested once (after the initial load and its not paginating)

PR Checklist:

  • [] Added Unit / UI tests
  • Self Review (review, clean up, documentation, run tests)
  • Basic Self QA

Screenshots

@bassrock bassrock requested a review from a team as a code owner March 15, 2023 15:53
@bassrock bassrock merged commit 5d3755f into develop Mar 15, 2023
@bassrock bassrock deleted the remove-duplicate-call branch March 15, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timc-mozilla timc-mozilla timc-mozilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bassrock @timc-mozilla