feat(premium): offline premium upsell #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PocketKit: Coverage: 82.48
Generated by 🚫 Danger Swift against a1f5c3f |
Gio2018
reviewed
Mar 14, 2023
There was a problem hiding this comment.
Hey @timc-mozilla , as shared on Slack, I am still seeing the regular premium upgrade view after going offline, is this expected?
Gio2018
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Awesome @timc-mozilla !! Approving this, we just need to follow up on updating the screen when connection status changes while still viewing the screen, but we can totally follow up with another PR!
| ZStack(alignment: .topTrailing) { | ||
| if viewModel.annualName.isEmpty { | ||
| PremiumUpgradeButton(isYearly: true) | ||
| if !viewModel.isOffline { |
There was a problem hiding this comment.
The online view could potentially be extracted into its own view for more readability, but it's nothing blocking and we can address it in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
Implementation Details
Test Steps
PR Checklist:
Screenshots