feat(pagination): smart pagination #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PocketKit: Coverage: 75.59
Sync: Coverage: 88.96
Generated by 🚫 Danger Swift against 33faed6 |
cyndichin
reviewed
Mar 10, 2023
cyndichin
reviewed
Mar 10, 2023
cyndichin
reviewed
Mar 10, 2023
Comment on lines
1
to
6
| // | ||
| // File.swift | ||
| // | ||
| // | ||
| // Created by Daniel Brooks on 3/9/23. | ||
| // |
There was a problem hiding this comment.
update with other Source Code Form header?
cyndichin
reviewed
Mar 10, 2023
|
|
||
| import Foundation | ||
|
|
||
| struct SyncConstants { |
There was a problem hiding this comment.
awesome! maybe we want to add Search constants here too in the future
cyndichin
reviewed
Mar 10, 2023
| @@ -199,6 +198,9 @@ class FetchSavesTests: XCTestCase { | |||
|
|
|||
| func test_refresh_whenItemCountExceedsMax_fetchesMaxNumberOfItems() async throws { | |||
| var fetches = 0 | |||
| let pages = Int(ceil(Double((SyncConstants.Saves.firstLoadMaxCount - SyncConstants.Saves.initalPageSize) / SyncConstants.Saves.pageSize))) + 2 | |||
There was a problem hiding this comment.
shall we add tests for Archive as well?
cyndichin
approved these changes
Mar 10, 2023
bassrock
force-pushed
the
smart-pagination
branch
from
1b11869
to
a4e41fb
Compare
bassrock
force-pushed
the
smart-pagination
branch
from
60348ef
to
a52b7b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
Implementation Details
Chose 500 items for now, will align with @nzeltzer and leadership later on for our launch size.
I also updated our large lists to have new data, but didn't change the data within. I want to find a tool to do that for us instead of sitting manually doing that.
Test Steps
PR Checklist:
Screenshots