Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data): remove static data cleaner #477

Merged
merged 5 commits into from
Mar 10, 2023
Merged

fix(data): remove static data cleaner #477

merged 5 commits into from
Mar 10, 2023

Conversation

bassrock
Copy link
Member

Summary

In local environments Home and all saves data would be deleted upon second launch of the app if logged in. Turns out this is because local environments are build <= 70.

This code was introduced in f1e428b and is no longer needed.

@bassrock bassrock requested a review from a team as a code owner March 10, 2023 00:12
@pocket-ci
Copy link
Contributor

pocket-ci commented Mar 10, 2023

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 77.31%
📖 Edited 4 files
📖 Created 0 files

PocketKit: Coverage: 75.5

File Coverage
PocketAppDelegate.swift 100.0%
HomeRefreshCoordinator.swift 94.52%

Sync: Coverage: 88.96

File Coverage
Log.swift 86.96%
SlateService.swift 81.48%

Generated by 🚫 Danger Swift against c63376b

@bassrock bassrock merged commit 14f8cca into develop Mar 10, 2023
@bassrock bassrock deleted the home-data-cleanup branch March 10, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants