feat(coredata): updating coredata and creating initalizers

[bassrock]

Summary

• Update Item, Slate, SlateLineup, Recomendation to make certain coredata fields non-null
• Create new initializer files using a Swift hack on initializers. (thanks swift and coredata 😮‍💨 )
• Update all uses of optional fields
  • Create another pr with a common logger. feat(logger): adding in a logger utility class #397
  • Wait for log pr to merge and change any guards to use it.
• Remove convenience new initializer for core data. So we use the custom inits.

References

• Links to docs, tickets, designs if available

Implementation Details

• Overview of work that was implemented and changes made to the codebase

Test Steps

• Write out what QA should do to verify this change works as expected and hasn't introduced regressions. Can mention specific OS versions, devices, areas of the app to test as needed.

PR Checklist:

• Added Unit / UI tests
• Self Review (review, clean up, documentation, run tests)
• Basic Self QA

Screenshots

[pocket-ci]

	Messages
📖	No SwiftLint violations! 🎉
📖	Project coverage: 75.82%
📖	Edited 30 files
📖	Created 11 files

PocketKit: Coverage: 75.07

File	Coverage
SlateDetailViewModel.swift	93.48%	✅
HomeViewModel.swift	86.79%	✅
SavedItem+ItemsListItem.swift	100.0%	✅
HomeRecommendationCellViewModel.swift	100.0%	✅

Sync: Coverage: 89.4

File	Coverage
SavedItem+RemoteMapping.swift	90.47%	✅
Recommendation+CoreDataProperties.swift	100.0%	✅
ArchiveService.swift	96.66%	✅
Space.swift	84.58%	✅
PocketSource.swift	87.44%	✅
SavedItem+CoreDataClass.swift	60.0%	✅
Slate+CoreDataProperties.swift	100.0%	✅
SlateLineup+CoreDataProperties.swift	100.0%	✅
Slate+CoreDataClass.swift	43.75%	⚠️
Item+CoreDataProperties.swift	100.0%	✅
SlateLineup+CoreDataClass.swift	43.75%	⚠️
Item+remoteMapping.swift	91.62%	✅
Item+CoreDataClass.swift	60.0%	✅
SlateService.swift	83.02%	✅
SlateLineup+remoteMapping.swift	91.94%	✅
SavedItem+CoreDataProperties.swift	100.0%	✅
Recommendation+CoreDataClass.swift	35.71%	⚠️
PocketSaveService.swift	92.09%	✅
FetchList.swift	98.78%	✅

Generated by 🚫 Danger Swift against bc25116

[cyndichin]

on a high level looks good, didn't do a thorough review. We can fix issues if we encounter them.