Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smartling translations are updated for commit 6fbfb3db389a26cedfc4223fe9b8949a4dd1b34b from develop #380

Merged
merged 17 commits into from
Feb 10, 2023

Conversation

bassrock
Copy link
Member

@bassrock bassrock commented Feb 8, 2023

Please review updates and merge this pull request

@bassrock bassrock requested a review from a team as a code owner February 8, 2023 21:46
@pocket-ci
Copy link
Contributor

pocket-ci commented Feb 8, 2023

Messages
📖 No SwiftLint violations! 🎉
📖 Edited 5 files
📖 Created 10 files

Generated by 🚫 Danger Swift against 43f1707

Copy link
Contributor

@cyndichin cyndichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are here, can we delete the other localizable files that contain "Home"? i.e. now we have two files for germany de-DE and de.lproj

image

@bassrock
Copy link
Member Author

bassrock commented Feb 9, 2023

oh. @cyndichin i think maybe i messed up the file paths?

@bassrock
Copy link
Member Author

bassrock commented Feb 9, 2023

I'll wait for smartling to finish and then fix it up

@cyndichin
Copy link
Contributor

oh. @cyndichin i think maybe i messed up the file paths?

I think our original file paths were not using the proper names, so I'm okay to revert those and use what smartling gives us now.

@bassrock bassrock merged commit 4efbda3 into develop Feb 10, 2023
@bassrock bassrock deleted the smartling-content-updated-vdufyjb9bjlm-from-develop branch February 10, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants