Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit/Add tags improvements #1063

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Edit/Add tags improvements #1063

merged 4 commits into from
Aug 21, 2024

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented Aug 21, 2024

Goal

  • Improve the add/edit tags experience:
    • Allow to save a tag typed in the text field without the need of hitting return before tapping "Save"
      • Applies to both the app and the save extension
    • Localize the edit tags view
    • Update the view title depending on whether or not there are existing tags. If there aren't, it'll be "Add Tags", otherwise "Edit tags"
  • This PR also bumps dependencies to the latest available

Test Steps

  • Add/edit tags and make sure the behavior matched what's described in the above section

Screenshots

RocketSim_Recording_iPhone_15_6.1_2024-08-21_14.44.17.mp4

@Gio2018 Gio2018 added bug Something isn't working tags labels Aug 21, 2024
@Gio2018 Gio2018 added this to the 8.17.0 milestone Aug 21, 2024
@Gio2018 Gio2018 self-assigned this Aug 21, 2024
@Gio2018 Gio2018 requested a review from bassrock as a code owner August 21, 2024 19:48
@pocket-ci
Copy link
Contributor

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 39.91%
📖 Checking XCode Environment Variables
📖 Edited 5 files
📖 Created 0 files

PocketKit: Coverage: 62.62

File Coverage
PocketAddTagsViewModel.swift 81.4%

SaveToPocketKit: Coverage: 29.07

File Coverage
SaveToAddTagsViewModel.swift 80.95%

SharedPocketKit: Coverage: 63.5

File Coverage
AddTagsView.swift 0.0% ⚠️
AddTagsViewModel.swift 72.5%

SaveToPocketKitTests: Coverage: 0.0

File Coverage
SaveToAddTagsViewModel.swift 0.0% ⚠️

SharedPocketKitTests: Coverage: 29.88

File Coverage
AddTagsView.swift 0.0% ⚠️
AddTagsViewModel.swift 0.0% ⚠️

PocketKitTests: Coverage: 28.97

File Coverage
AddTagsView.swift 0.0% ⚠️
AddTagsViewModel.swift 0.0% ⚠️
PocketAddTagsViewModel.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 502563f

@Gio2018 Gio2018 merged commit 159c999 into develop Aug 21, 2024
8 checks passed
@Gio2018 Gio2018 deleted the POCKET-10441-improve-tag-saves branch August 21, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tags
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants