Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed Out Home - Remove feature flag #1062

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented Aug 20, 2024

Goal

  • Remove feature flag for Signed Out Home

Test Steps

Screenshots

see #1033

@Gio2018 Gio2018 added this to the 8.17.0 milestone Aug 20, 2024
@Gio2018 Gio2018 self-assigned this Aug 20, 2024
@Gio2018 Gio2018 requested a review from bassrock as a code owner August 20, 2024 18:22
@Gio2018 Gio2018 changed the base branch from develop to feat/POCKET-10294-continue-signed-out August 20, 2024 18:22
@pocket-ci
Copy link
Contributor

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 37.54%
📖 Checking XCode Environment Variables
📖 Edited 3 files
📖 Created 0 files

PocketKit: Coverage: 62.56

File Coverage
LoggedOutViewController.swift 0.0% ⚠️
LoggedOutViewModel.swift 70.11%

SharedPocketKit: Coverage: 63.5

File Coverage
CurrentFeatureFlags.swift 0.0% ⚠️

SharedPocketKitTests: Coverage: 29.88

File Coverage
CurrentFeatureFlags.swift 0.0% ⚠️

PocketKitTests: Coverage: 28.97

File Coverage
LoggedOutViewController.swift 0.0% ⚠️
CurrentFeatureFlags.swift 0.0% ⚠️
LoggedOutViewModel.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 0860331

@Gio2018 Gio2018 merged commit 5dd9742 into feat/POCKET-10294-continue-signed-out Aug 20, 2024
8 checks passed
@Gio2018 Gio2018 deleted the feat/POCKET-10317-remove-signed-out-feature-flat branch August 20, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants