Search Saves via Siri or App Shortcuts #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Analytics: Coverage: 59.14
Pocket.app: Coverage: 75.56
PocketKit: Coverage: 62.61
AnalyticsTests: Coverage: 24.08
PocketKitTests: Coverage: 28.98
Generated by 🚫 Danger Swift against 2001381 |
Gio2018
force-pushed
the
feat/POCKET-10294-continue-signed-out
branch
from
3cd9a62
to
03aaf0a
Compare
Gio2018
force-pushed
the
feat/siri-search
branch
from
47a2797
to
eb96681
Compare
Base automatically changed from
feat/POCKET-10294-continue-signed-out
to
develop
August 20, 2024 21:34
Gio2018
force-pushed
the
feat/siri-search
branch
2 times, most recently
from
8dd7e90
to
9c6d7bf
Compare
Gio2018
force-pushed
the
feat/siri-search
branch
from
e8104fe
to
4c7b946
Compare
bassrock
approved these changes
Aug 29, 2024
| @@ -0,0 +1,3 @@ | |||
| "Show me some cool stuff in ${applicationName}" = "Zeig mir coole Sachen in ${applicationName}"; | |||
There was a problem hiding this comment.
Should we setup this file path in smartling?
There was a problem hiding this comment.
eventually, though I am still trying to figure out if we can leverage our Localization package and SwiftGen, so the localization on Intents is still kinda WIP, but this works nonetheless.
Gio2018
force-pushed
the
feat/siri-search
branch
2 times, most recently
from
b1b99d9
to
2001381
Compare
…rch bar is the first responder when search is activated via intent
…o ensure the searchController life cycle is triggered correctly
Gio2018
force-pushed
the
feat/siri-search
branch
from
2001381
to
85702ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Note
As of now, the search is intentionally limited to
Saves(notArchivenorAll)Test Steps
Issue(s)
POCKET-10508
Video
Screen.Recording.2024-08-29.at.4.35.53.PM.mov