Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tags not deleted from edit tags screen #1059

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented Aug 15, 2024

Goal

  • In the "Edit Tags" screen accessible from the overflow menu of the Reader in a saved item, deleting a tag and tapping "Save" did not actually delete the tag. this PR fixes the bug.
  • This PR also updates Sentry to 8.34.0

Test Steps

  • Build/run this branch
  • From either the Saves screen or the Recent Saves section on Home, select a saved item
  • Tap the overflow menu, then "Edit Tags"
  • Edit tags at will, and particularly delete existing ones, and make sure they are actually deleted
  • Go back in the saves list, pull to refresh and make sure deleted tags do not reappear in the selected item.

Screenshots

…gs() to saveTags() to better reflect the nature of the call

* Update PocketAddTagsViewModel, replace call to addTags() with replaceTags() in saveTags()
@Gio2018 Gio2018 added bug Something isn't working tags labels Aug 15, 2024
@Gio2018 Gio2018 added this to the 8.16.0 milestone Aug 15, 2024
@Gio2018 Gio2018 self-assigned this Aug 15, 2024
@Gio2018 Gio2018 requested a review from bassrock as a code owner August 15, 2024 21:20
@pocket-ci
Copy link
Contributor

pocket-ci commented Aug 15, 2024

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 37.46%
📖 Checking XCode Environment Variables
📖 Edited 13 files
📖 Created 2 files

PocketKit: Coverage: 63.07

File Coverage
PocketAddTagsViewModel.swift 81.25%

SaveToPocketKit: Coverage: 28.6

File Coverage
SaveToAddTagsViewModel.swift 80.8%

SharedPocketKit: Coverage: 62.45

File Coverage
AddTagsView.swift 0.0% ⚠️
AddTagsViewModel.swift 72.5%

Sync: Coverage: 71.78

File Coverage
SyncTask.swift 88.89%
PocketSource.swift 57.44%

SaveToPocketKitTests: Coverage: 0.0

File Coverage
SaveToAddTagsViewModel.swift 0.0% ⚠️
SaveToAddTagsViewModelTests.swift 0.0% ⚠️

SyncTests: Coverage: 22.74

File Coverage
SyncTask.swift 88.89%
PocketSource.swift 19.33% ⚠️

SharedPocketKitTests: Coverage: 28.09

File Coverage
AddTagsView.swift 0.0% ⚠️
AddTagsViewModel.swift 0.0% ⚠️

PocketKitTests: Coverage: 28.44

File Coverage
PocketAddTagsViewModelTests.swift 0.0% ⚠️
AddTagsView.swift 0.0% ⚠️
AddTagsViewModel.swift 0.0% ⚠️
MockSource.swift 0.0% ⚠️
PocketAddTagsViewModel.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 5b19bba

@Gio2018 Gio2018 merged commit 0529e92 into develop Aug 15, 2024
8 checks passed
@Gio2018 Gio2018 deleted the POCKET-10427-tags-not-removed branch August 15, 2024 22:55
Copy link

sentry-io bot commented Aug 16, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ App Hanging: App hanging for at least 2000 ms. SavesContainerViewController View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tags
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants