Fix crash upon SwiftUICollectionViewCell deinit and add some more breadcrumbs and optimization in HomeViewModel snapshot calculation and rendering
#1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… controller - this cell retained unnecessary hosting controller to embed a SwiftUI view inside a UIKit UIView - moreover, it attempted to manually destroy the hosting vc upon denit (also not necessary), causing crashes sometimes
PocketKit: Coverage: 63.1
PocketKitTests: Coverage: 28.27
Generated by 🚫 Danger Swift against 292b62c |
…d unnecessary layout updates that trigger as many buildSnapshot()...
Gio2018
changed the title
SwiftUICollectionViewCell deinitSwiftUICollectionViewCell deinit and add some more breadcrumbs and optimization in HomeViewModel snapshot calculation and rendering
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
SwiftUICollectionViewCellcell retained unnecessary hosting controller to embed a SwiftUI view inside a UIKit UIViewdenit(also not necessary), causing crashes sometimes. Removing that reference and the code insidedeinitentirely, should address the crashNSInternalInconsistencyExceptioncrash that occurs in HomehomeViewController.traitCollectionchanged...