Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix listen not working from home #1051

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented Jul 26, 2024

Goal

  • Fix a bug where listen was not working when opening a recent saves item from home. This was because the listen presenting logic was baked into SavesContainerViewController. We could have added the same logic to HomeViewController, but a better solution was to move it to ReadableHostViewController, so that Listen would work regardless where we decide to present the saved article from.

Test Steps

  • Build/run
  • Open an article from Home/Recent Saves
  • Make sure listen works
  • Also test listen from Saves and from Saves list, and make sure it still works as expected.

…roller to ReadableHostViewController, so that we can listen to articles regardless where we present them from..
@Gio2018 Gio2018 added bug Something isn't working Listen labels Jul 26, 2024
@Gio2018 Gio2018 added this to the 8.15.0 milestone Jul 26, 2024
@Gio2018 Gio2018 self-assigned this Jul 26, 2024
@Gio2018 Gio2018 requested a review from bassrock as a code owner July 26, 2024 15:52
@pocket-ci
Copy link
Contributor

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 37.23%
📖 Checking XCode Environment Variables
📖 Edited 2 files
📖 Created 0 files

PocketKit: Coverage: 63.09

File Coverage
ReadableHostViewController.swift 81.73%
SavesContainerViewController.swift 74.31%

PocketKitTests: Coverage: 28.23

File Coverage
SavesContainerViewController.swift 50.69%
ReadableHostViewController.swift 53.85%

Generated by 🚫 Danger Swift against fccc45b

Copy link
Collaborator

@nzeltzer nzeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution :)

@Gio2018 Gio2018 merged commit 0479f2e into develop Jul 26, 2024
8 checks passed
@Gio2018 Gio2018 deleted the fix/POCKET-10353-listen-from-home branch July 26, 2024 17:23
Copy link

sentry-io bot commented Jul 26, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ App Hanging: App hanging for at least 2000 ms. UITabBar._sendAction(withEvent:) View Issue
  • ‼️ App Hanging: App hanging for at least 2000 ms. SavesContainerViewController View Issue
  • ‼️ App Hanging: App hanging for at least 2000 ms. _UINavigationBarContentView.__backButtonAction View Issue
  • ‼️ App Hanging: App hanging for at least 2000 ms. -[PKTTextToSpeech initWithConfiguration:] View Issue
  • ‼️ App Hanging: App hanging for at least 2000 ms. HeadingComponent.init View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Listen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants