Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new onboarding screen #1032

Merged
merged 8 commits into from
Jul 9, 2024
Merged

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented Jul 8, 2024

Goal

  • Add the new onboarding screen that includes the "Continue signed out" button as well as privacy and TOS links

Test Steps

  • enable the temp.ios.newOnboarding feature flag, or just set the showNewOnboarding = true in LoggedOutViewModel, line 97
  • Verify that the new onboarding screen appears (see screenshot)
  • Verify that the "Sign up or sign in" behaves as the existing "Continue" button
  • Verify that privacy and tos links work

Important

if you enable the feature flag, remember to disable it!

Note

the "Continue signed out" button, currently does nothing and that's expected.

Screenshots

@Gio2018 Gio2018 added enhancement New feature or request Signed Out Experience labels Jul 8, 2024
@Gio2018 Gio2018 self-assigned this Jul 8, 2024
@Gio2018 Gio2018 requested a review from bassrock as a code owner July 8, 2024 23:10
@pocket-ci
Copy link
Contributor

pocket-ci commented Jul 8, 2024

Fails
🚫 Failed to get the coverage - Error: The data couldn’t be read because it isn’t in the correct format.
Messages
📖 No SwiftLint violations! 🎉
📖 Checking XCode Environment Variables
📖 Edited 7 files
📖 Created 0 files

Generated by 🚫 Danger Swift against 9fea2e4

@Gio2018 Gio2018 merged commit a324bdd into develop Jul 9, 2024
1 check failed
@Gio2018 Gio2018 deleted the feat/10296-new-onboarding-screen branch July 9, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants