Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sidecar #37

Closed
dgkanatsios opened this issue Oct 17, 2021 · 1 comment
Closed

Refactor sidecar #37

dgkanatsios opened this issue Oct 17, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@dgkanatsios
Copy link
Collaborator

#31 introduced some changes to the sidecar, in the way that the sidecar finds out about the GameServer state change. As a result of that, we'll need to refactor the httphandler.go file.

  • Maybe split it into two structs with different responsibility?
  • rename the file/struct?
@dgkanatsios dgkanatsios added the enhancement New feature or request label Oct 17, 2021
This was referenced Oct 28, 2021
Closed
Merged
@dgkanatsios dgkanatsios mentioned this issue Nov 13, 2021
Merged
@dgkanatsios
Copy link
Collaborator Author

Fixed in #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dgkanatsios