Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ED2IN tags not in template aren't added from pecan.xml #3034

Closed
Aariq opened this issue Sep 14, 2022 · 0 comments · Fixed by #3035
Closed

ED2IN tags not in template aren't added from pecan.xml #3034

Aariq opened this issue Sep 14, 2022 · 0 comments · Fixed by #3035

Comments

@Aariq
Copy link
Collaborator

Aariq commented Sep 14, 2022

Bug Description

According to the documentation, ED2IN tags that aren't in the template ED2IN file can still be added by supplying them to the <ed2in_tags> tag in pecan.xml. The new tags are succesfully added to a list by modify_ed2in(), but write_ed2in() fails to add the new values here:

file_body[attr(ed2in, "value_linenos")] <- tags_values_vec

When there are new ED2IN tags, these vectors are of different lengths and the new vectors aren't added.

To Reproduce

Steps to reproduce the behavior:
Add an arbitrary <ed2in_tags> to pecan.xml, read in settings, run run.write.configs(settings), inspect ED2IN in run folder

Expected behavior

New tags should be added at the bottom of the ED2IN file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant