Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add troubleshooting guidance for SQL Encrypt breaking change #5692

Merged
merged 7 commits into from
Mar 29, 2022

Conversation

mikeminutillo
Copy link
Member

Microsoft.Data.SqlClient version 4 includes a breaking change dotnet/SqlClient#1210 which causes existing clients to throw an exception when using the default configuration:

System.Data.SqlClient.SqlException
  HResult=0x80131904
  Message=A connection was successfully established with the server, but then an error occurred during the login process. (provider: SSL Provider, error: 0 - The certificate chain was issued by an authority that is not trusted.)
  Source=.Net SqlClient Data Provider

@mikeminutillo mikeminutillo self-assigned this Mar 24, 2022
Copy link
Member

@tmasternak tmasternak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Minor question: can we remove duplication from the guidance files?

@mikeminutillo
Copy link
Member Author

Duplication (mostly) removed. I pulled the guidance out of the individual upgrade guides and created a specific upgrade guide for upgrading to SqlClient 4 in both SQL-T and SQL-P. The ServiceControl one has slightly different text so I left it as a "duplicate"

@mikeminutillo mikeminutillo marked this pull request as ready for review March 25, 2022 06:36
Copy link
Contributor

@timbussmann timbussmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpick

servicecontrol/troubleshooting.md Outdated Show resolved Hide resolved
@mikeminutillo mikeminutillo merged commit ae5854b into master Mar 29, 2022
@mikeminutillo mikeminutillo deleted the sql-encryption-troubleshooting branch March 29, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants