Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.12 #2675

Merged
merged 49 commits into from
Dec 27, 2023
Merged

Support Python 3.12 #2675

merged 49 commits into from
Dec 27, 2023

Conversation

benclifford
Copy link
Collaborator

@benclifford benclifford commented May 2, 2023

This PR makes Parsl support Python 3.12.

  • The pandas dependency for visualization is loosened to allow more recent pandas version.

  • The CI python build step is upgraded, and Python 3.12 is added

Original description:

Python 3.12 beta 1 is expected soon. Usually with a new python version, there are a handful of things that break or change. This branch is to discover those, ideally before Python 3.12.0.

See https://peps.python.org/pep-0693/ for Python 3.12 release timetime

Type of change

  • Code maintentance/cleanup

@benclifford
Copy link
Collaborator Author

right now this build is failing for pyzmq and greenlet, both in compiling some C code that references the cpython api

@benclifford
Copy link
Collaborator Author

pandas (used by monitoring viz and some tests) doesn't build because distutils is gone in python 3.12 and it seems to want to build that way.

i removed it (so expect monitoring viz and those tests to fail, but this is too see how far along the build can get.

back to failing with pyzmq building greenlets C API stuff I encountered before

@benclifford
Copy link
Collaborator Author

for greenlets, see issue/likely fix here: python-greenlet/greenlet#357

@benclifford
Copy link
Collaborator Author

flake8 6.0.0 installs ok, but it is very confused about source code structure - for example, it's seems to be regarding multiline docstrings as a single extra-long line, which is then not permitted due to line length linting.

and many blank line at the end of file errors when there is no blank line there.

@benclifford
Copy link
Collaborator Author

#2737 now merged upgrades flake8

@benclifford benclifford changed the title Begin preparations for Python 3.12 Preparations for Python 3.12 Sep 21, 2023
@benclifford benclifford changed the title Preparations for Python 3.12 Test Python 3.12 in CI Dec 19, 2023
@benclifford benclifford changed the title Test Python 3.12 in CI Support Python 3.12 Dec 19, 2023
@benclifford benclifford marked this pull request as ready for review December 19, 2023 09:56
@benclifford benclifford merged commit 2862f1d into master Dec 27, 2023
6 checks passed
@benclifford benclifford deleted the benc-python-3.12 branch December 27, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants