Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Additional Supported Post Schema @types #1899

Closed
BrookeDot opened this issue Oct 4, 2023 · 1 comment · Fixed by #1915
Closed

Add Additional Supported Post Schema @types #1899

BrookeDot opened this issue Oct 4, 2023 · 1 comment · Fixed by #1915
Assignees
Milestone

Comments

@BrookeDot
Copy link

Describe the bug

Parse.ly currently supports 17 @types for post content in the JSON-LD output:
https://docs.parse.ly/metadata-jsonld/#h-type-values-that-parse-ly-recognizes-as-posts

However, the WordPress plugin only supports 8.
https://github.com/Parsely/wp-parsely/blob/develop/src/class-parsely.php#L93-L110

The missing @types are:

The plugin will return index if the type is not one of the 8 supported content types:
https://github.com/Parsely/wp-parsely/blob/develop/src/class-parsely.php#L508-L524

This can be replicated by using the following filter:

function podcast_wp_parsely_metadata( $parsely_page, $post, $options ) {
    
   $parsely_page['@type']  = 'PodcastEpisode';
    return $parsely_page;
}
add_filter( 'wp_parsely_metadata', 'podcast_wp_parsely_metadata', 10, 3 );

Expected behavior

All @types supported by Parse.ly are support by the WordPress plugin.

@acicovic acicovic added this to the 3.11.0 milestone Oct 4, 2023
@vaurdan vaurdan self-assigned this Oct 11, 2023
@vaurdan vaurdan linked a pull request Oct 11, 2023 that will close this issue
@acicovic
Copy link
Collaborator

@BrookeDot, a fix has been created and merged. It will become available in our next release. Thanks for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants