Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp to header #7

Closed
thomascobb opened this issue Jan 29, 2021 · 4 comments · Fixed by #34
Closed

Add timestamp to header #7

thomascobb opened this issue Jan 29, 2021 · 4 comments · Fixed by #34
Assignees

Comments

@thomascobb
Copy link

Currently PCAP has relative timestamps for things like TS_CAPTURE. MAX IV would like to relate this to an absolute timestamp that is provided in the header of the capture. This can be provided by NTP now, but in the future may be provided by the timestamp from the EVR.

@Araneidae
Copy link
Contributor

I like the approach suggested by @valerixb, but this leaves open the question of when capture actually started. Will the ARM timestamp be enough to solve this, or are we also going to want the driver to capture a timestamp when capture begins? This may be tricky, as data only starts to arrive after a buffer's worth has been seen, or a timeout.

@thomascobb
Copy link
Author

How about this, for now we add pcap_arm_time which is accurate to NTP (a couple of ms?). In the future we can add a second pcap_enable_time which is raised as an interrupt when PCAP.ENABLE goes high after an ARM, which is accurate to the latency of getting an interrupt into the ARM (not sure how accurate this is?)

@Araneidae
Copy link
Contributor

Sounds good to me. We'd have to add an ENABLE interrupt, or capture a hardware timestamp in firmware.

@coretl
Copy link
Contributor

coretl commented Oct 5, 2022

PandABlocks/PandABlocks-FPGA#88 needs to be done first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants