Sniffing for

[PatrickRose]

Arguably we shouldn't have written this anyway, but we've found that the following is now a compile time error in PHP instead of a runtime error:

$ less tmp.php
<?php

function hello() {
    if (true) {
        continue;
    }
}
$ php56 tmp.php

$ php70 tmp.php
PHP Fatal error:  'continue' not in the 'loop' or 'switch' context in tmp.php on line 5

It was a fatal runtime error in PHP5.6 but because it was nested inside some error handling code in our case it was never hit. Same is true with break.

[wimg]

Sadly this is one that will be extremely hard to detect. In fact we can never cover all cases of this. Unless someone has a brilliant idea for this ? @jrfnl ?

[jrfnl]

@wimg I am already thinking about it, got some ideas, but will need to test them out to be sure ;-)

[jrfnl]

Ok, I think I've got it, now off to build it.

[jrfnl]

Ok, this should work. PR #278 should handle this. Testing appreciated, including coming up with more test cases to see if the sniff handles them correctly.