Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for 5.3 #145

Closed
Potherca opened this issue Jan 25, 2022 · 1 comment · Fixed by #147
Closed

Drop support for 5.3 #145

Potherca opened this issue Jan 25, 2022 · 1 comment · Fixed by #147

Comments

@Potherca
Copy link
Member

Based on the usage statistics from Packagist and supported versions from PHP_CS we no longer need to support 5.3.

Support can be dropped before we label a stable 1.0 version

@Potherca Potherca pinned this issue Jan 25, 2022
@jrfnl
Copy link
Member

jrfnl commented Jan 25, 2022

I'm all for it. 👍🏻

PHPCS 3.x has been out for over four years now (May 2017) and dropped support for PHP 5.3 as well, so I would think most external standards will be using PHPCS 3.x by now and for those who still use PHPCS 2.x, PHP 5.4 would be the new minimum for the plugin and is fully supported on PHPCS 2.x.

It will also simplify a number of things for getting the tests up and running.

The PHP usage stats for this plugin can be found here: https://packagist.org/packages/dealerdirect/phpcodesniffer-composer-installer/php-stats

And this is the status per today:
image

The PHPCS version usage stats can be seen here: https://packagist.org/packages/squizlabs/php_codesniffer/stats

With this showing that PHPCS 2.x usage is down to ~2% of all PHPCS installs over the last year or so:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants