Import unit tests for Owned, OpsManaged and SafeMath #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhayks1
reviewed
Dec 15, 2017
| // Copyright 2017 OpenST Ltd. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. |
There was a problem hiding this comment.
any specific reason for SafeMatchMock contract? Can't we use SafeMatch contract in SafeMath.js directly?
abhayks1
reviewed
Dec 15, 2017
| import "./SafeMath.sol"; | ||
|
|
||
|
|
||
| contract SafeMathMock { |
There was a problem hiding this comment.
Do we need "is SafeMath" to inherit SafeMath.sol functionality here?
There was a problem hiding this comment.
the idea is to have this contract call on SafeMath.sol (and inheriting it may tell the compiler to optimise it out)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4