Remove signature from stake #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 13, 2018 12:37
0xsarvesh
requested review from
schemar,
benjaminbollen,
deepesh-kn and
gulshanvasnani
schemar
reviewed
Dec 14, 2018
There was a problem hiding this comment.
Good code and nice clean-up 🚁 🚁 🎧
It looks good to me 🎉 But someone else definitely has to take a look at this (@deepesh-kn).
Is it really as easy as just removing the signature? No other side effects from that?
Is it really required to have that much code in the mock message bus, though? That looks dangerous to me
| abi.encodePacked(path) | ||
| ) | ||
| ) | ||
| ); |
There was a problem hiding this comment.
Is it correct to be hashed twice? 🤔
There was a problem hiding this comment.
Is it possibly a bug in the JS as well? What's the reason for hashing it twice?
deepesh-kn
reviewed
Dec 17, 2018
added 4 commits
December 17, 2018 22:08
0xsarvesh
commented
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes #539
The following features are implemented as a part of this PR.
EIP20Gateway.stakeis called by Staker without providing staker signature.MessageBus.declareMessagealso modified to not accept the signature.As bounty is transferred from staker/redeemer, the gateway only knows about one actor.
Gateway doesn't care about how staker and facilitator shares hash lock, unlock secret and bounty.
Note: This PR didn't touch unit test cases for
ProgressOutboxWithProofas those are covered in #526. Also, one test forProgressInboxWithProofwhich tests that transaction is reverted if Merkel proof verification failed should be covered after #526.