-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified the naming of RLP encoded parameters #528
Conversation
The name of an RLP encoded parameter now always starts with 'rlp' (or `_rlp` in case of a function argument) followed by the name, without the word `Encoded` in between. Examples: * `rlpAccount` * `rlpParentNodes` **BAD** example: `rlpEncodedParentNodes` Fixes OpenST#462
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We can consider to change rlpEncodedAccount
is used in the following lines.
file: test/data/proof.json
Line: 3
file: prove_origin_core.js
Line: 36
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eagle eyes again 👀 Updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🏇
The name of an RLP encoded parameter now always starts with 'rlp' (or
_rlp
in case of a function argument) followed by the name, without theword
Encoded
in between.Examples:
rlpAccount
rlpParentNodes
BAD example:
rlpEncodedParentNodes
Fixes #462