Remove cogateway deactivation logic #518
Conversation
|
@sarvesh-ost can you please merge develop and resolve the conflicts before we review it? |
It's now available for review. |
contracts/gateway/EIP20Gateway.sol
Outdated
| @@ -197,6 +200,17 @@ contract EIP20Gateway is GatewayBase { | |||
| /** Maps messageHash to the Unstake object. */ | |||
| mapping(bytes32 /*messageHash*/ => Unstake) unstakes; | |||
|
|
|||
| /* modifiers */ | |||
|
|
|||
| /** checks that contract is activated */ | |||
There was a problem hiding this comment.
| /** checks that contract is activated */ | |
| /** Checks that contract is active. */ |
|
|
||
| await _setup(accounts, gateway); | ||
| await _prepareData(); | ||
| await _stake(utils.ResultType.FAIL); |
There was a problem hiding this comment.
Where is the gateway activated in the other test cases? 😕
There was a problem hiding this comment.
Now we have the ability to activate.
So we can now delete TestEIP20Gateway contract.
Previously it was the part of linking process.
There was a problem hiding this comment.
In the mock contract, it has been set to true on construction.
Link
…_deactivation_logic
…com/sarvesh-ost/mosaic-contracts into remove_cogateway_deactivation_logic
|
|
||
| await _setup(accounts, gateway); | ||
| await _prepareData(); | ||
| await _stake(utils.ResultType.FAIL); |
There was a problem hiding this comment.
Now we have the ability to activate.
So we can now delete TestEIP20Gateway contract.
Previously it was the part of linking process.
This should be merged after #512
Removed deactivation logic from
GatewayBaseand now only gateway and co-gateway can be deactivated. Also, the stake can only be called if the gateway is activated.