Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar for recording and visualization #316

Closed
0dm opened this issue Jun 26, 2023 · 12 comments · Fixed by #318
Closed

Progress bar for recording and visualization #316

0dm opened this issue Jun 26, 2023 · 12 comments · Fixed by #318
Assignees
Labels
enhancement New feature or request

Comments

@0dm
Copy link
Collaborator

0dm commented Jun 26, 2023

Feature request

a progress bar after stopping a recording

resources:
https://github.com/tqdm/tqdm (used in scrub already)
or
https://github.com/rsalmei/alive-progress (could be better?)

Motivation

After recording, I'd like to know when it'll be done writing to the db. I usually just find myself tabbing out and watching the file size grow to gain some sense of progress 😅

@0dm 0dm added the enhancement New feature or request label Jun 26, 2023
@abrichr
Copy link
Member

abrichr commented Jun 26, 2023

Thanks @0dm 🙏 alive-progress looks sweet!

@KrishPatel13
Copy link
Collaborator

@0dm Have you started to work on this ? Or should I take it over ? :)

@0dm
Copy link
Collaborator Author

0dm commented Jun 26, 2023

@0dm Have you started to work on this ? Or should I take it over ? :)

haven't started, feel free to work on it!

@KrishPatel13 KrishPatel13 self-assigned this Jun 26, 2023
@KrishPatel13
Copy link
Collaborator

No worries, I will put a PR for it today! @abrichr

@KrishPatel13
Copy link
Collaborator

@abrichr /@0dm Should I also include the progress bar for Visualization ?

@0dm
Copy link
Collaborator Author

0dm commented Jun 26, 2023

@abrichr /@0dm Should I also include the progress bar for Visualization ?

That'd be pretty nice, there already is some indication of when it finishes if you count the number of action events it processes, but a bar would be great.

@KrishPatel13
Copy link
Collaborator

Cool! So I will include Progress bar for both record and visualize,

@KrishPatel13
Copy link
Collaborator

Some visuals for the Progress bar during Visualization:
clideo_editor_914f802dd3c246e4836b5b2d96de8115

@KrishPatel13
Copy link
Collaborator

PLease let me know if this progress bar is good to go :?

@KrishPatel13
Copy link
Collaborator

I will now add in record.py.

@0dm
Copy link
Collaborator Author

0dm commented Jun 26, 2023

Some visuals for the Progress bar during Visualization:
clideo_editor_914f802dd3c246e4836b5b2d96de8115

nice!

@KrishPatel13
Copy link
Collaborator

KrishPatel13 commented Jun 26, 2023

For record.py it will be a bit messy from what I have done here:

It is because of threads
record py - OpenAdapt - Visual Studio Code - Insiders 2023-06-26 12-08-54 (1)

@KrishPatel13 KrishPatel13 changed the title Progress bar for recording Progress bar for recording and visualization Jun 26, 2023
@KrishPatel13 KrishPatel13 linked a pull request Jun 28, 2023 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants