Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Setting OneSignal.Notifications.requestPermission parameter fallbackToSettings to false has no effect #1727

Closed
2 of 3 tasks
hrastnik opened this issue Aug 8, 2024 · 4 comments

Comments

@hrastnik
Copy link

hrastnik commented Aug 8, 2024

What happened?

When calling OneSignal.Notifications.requestPermission it's possible to pass a parameter fallbackToSettings which should control whether the in-app Open Settings prompt will display when the native prompt has been rejected. However, this parameter has no effect and the Open Settings prompt shows always

Steps to reproduce?

1. Call `await OneSignal.Notifications.requestPermission(false);`
2. The "Open Settings" prompt will show

What did you expect to happen?

The prompt should not show up.

React Native OneSignal SDK version

5.2.2

Which platform(s) are affected?

  • iOS
  • Android

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@martin-key
Copy link

Same here. This issue should be marked as Major as we have received multiple reports by uses.

@aharonphytech
Copy link
Contributor

I opened PR addressing this issue:
#1729

@aharonphytech
Copy link
Contributor

@jennantilla, thank you for merging the PR. I believe the issue should be resolved now

@jennantilla
Copy link
Contributor

Thanks for your patience, everyone! Release 5.2.3 is ready. I'll go ahead and close this out but please let us know if there are any additional questions or concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants