From e3e9f2513fd519e686a7a9128089a2dbf2de4b0a Mon Sep 17 00:00:00 2001 From: Toru Date: Mon, 27 Sep 2021 15:05:49 +0900 Subject: [PATCH 1/2] Remove default callback function from `removeExternalUserId` --- src/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/index.js b/src/index.js index 1689ef56..440e0aa9 100644 --- a/src/index.js +++ b/src/index.js @@ -356,7 +356,7 @@ export default class OneSignal { static removeExternalUserId(handler) { if (!isObjectNonNull(RNOneSignal)) return; - if (handler === undefined) + if (handler === undefined && Platform.OS === 'ios') handler = function(){}; RNOneSignal.removeExternalUserId(handler); From f83ea6df7cd4d1b93df0af2cc57cc6a56f58080a Mon Sep 17 00:00:00 2001 From: Toru Date: Wed, 10 Nov 2021 07:48:42 +0900 Subject: [PATCH 2/2] Add comment about Android workaround --- src/index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/index.js b/src/index.js index 440e0aa9..f1fe3a4c 100644 --- a/src/index.js +++ b/src/index.js @@ -356,6 +356,7 @@ export default class OneSignal { static removeExternalUserId(handler) { if (!isObjectNonNull(RNOneSignal)) return; + // Android workaround for the current issue of callback fired more than once if (handler === undefined && Platform.OS === 'ios') handler = function(){};