Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open C# colorizing issues #101

Closed
aeschli opened this issue Mar 17, 2016 · 10 comments
Closed

Open C# colorizing issues #101

aeschli opened this issue Mar 17, 2016 · 10 comments
Labels
Bug Editor-Syntax Highlighting Resolved-Fixed
Milestone
1.7

Comments

@aeschli
Copy link
Contributor

aeschli commented Mar 17, 2016

FYI I created the following bugs against https://github.com/atom/language-csharp from issues reported against the c# snytax highlighting in VS Code.
I will close the corresponding bugs in the VSCode repository that we kept open to track any progress.

atom/language-csharp#48
atom/language-csharp#46
atom/language-csharp#43
atom/language-csharp#44
atom/language-csharp#45
This was referenced Mar 17, 2016
Closed
Closed
Closed
Closed
Closed
@ivanz ivanz mentioned this issue Aug 18, 2016
Merged
ivanz added a commit to ivanz/omnisharp-vscode that referenced this issue Aug 18, 2016
@ivanz
Fix highlighting of nested namespaces and using statements.
c1ed1cd 
Fixes dotnet#282, dotnet#849

Also the below which are tracked here: dotnet#101

microsoft/vscode#849
microsoft/vscode#848
@ivanz ivanz mentioned this issue Aug 18, 2016
Merged
ivanz added a commit to ivanz/omnisharp-vscode that referenced this issue Aug 18, 2016
@ivanz
Fix highlighting of nested namespaces and using statements.
8c77f7f 
Fixes dotnet#282, dotnet#849, dotnet#381

Also the below which are tracked here: dotnet#101

microsoft/vscode#849
microsoft/vscode#848
@ivanz
Copy link
Contributor

ivanz commented Aug 18, 2016

@DustinCampbell FYI All but one of those are fixed and I have created a separate issue for it here #687 - so you can close this one. I have an idea how to fix the remaining one and will have a look when I get a chance.

@DustinCampbell
Copy link
Member

@ivanz, do you think it'd make sense to port your fixes over to the (https://github.com/atom/language-csharp) repo?

@DustinCampbell
Copy link
Member

cc @david-driscoll as well. I'm not sure if the OmniSharp extension for Atom uses the same grammar or not.

@david-driscoll
Copy link
Contributor

Yeah, we use the built in csharp grammar from atom. The semantic highlighting is additive.

@DustinCampbell
Copy link
Member

Cool. So, porting these fixes to atom would be good for you too.

@david-driscoll
Copy link
Contributor

If you port them (which would be amazing!) feel free to cc me on the pull request. 👍

@DustinCampbell DustinCampbell added this to the 1.7 milestone Jan 10, 2017
@DustinCampbell
Copy link
Member

All of these are fixed for the next release.

@DustinCampbell DustinCampbell mentioned this issue Jan 11, 2017
Merged
@joshpritchard-fcx
Copy link

This release did not fix microsoft/vscode#848 so it should be re-opened. This is very annoying for me.

@DustinCampbell
Copy link
Member

@joshpritchard-fcx : Here's what the microsoft/vscode#848 repro looks like it the latest release of VS Code:

image

This appears to be correct to me. If you disagree, please feel free to file a new issue at https://github.com/dotnet/csharp-tmLanguage/issues.

@joshpritchard-fcx
Copy link

Thanks. Sorry for commenting here I guess what I am seeing is a separate issue.

This was referenced Nov 28, 2023
Open
Open
@TheRealPiotrP TheRealPiotrP mentioned this issue Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Editor-Syntax Highlighting Resolved-Fixed
Projects
None yet
Milestone
1.7
Development

No branches or pull requests
5 participants
@ivanz @DustinCampbell @david-driscoll @aeschli @joshpritchard-fcx